Use existing columns for 3x5 layout #22860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piantor v1 has a 36 key variant that is created by snapping off the outer columns from each half. This means that the left side uses columns 1-5 instead of 0-5 in the 42 key layout. It appears that the 3x5 layout here was added with the inner column removed on the left side. As such, 3x5 layouts will have a dead column on the inside and be missing the outer column from the layout. Update the layout to use columns 1-5 since column 0 does not exist on the 36 key piantor.
drashna
approved these changes
Jan 8, 2024
fauxpark
approved these changes
Jan 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Piantor v1 has a 36 key variant that is created by snapping off the
outer columns from each half. This means that the left side uses
columns 1-5 instead of 0-5 in the 42 key layout.
It appears that the 3x5 layout here was added (see #20328) with the inner column
removed on the left side. As such, 3x5 layouts will have a dead column
on the inside and be missing the outer column from the layout.
Update the layout to use columns 1-5 since column 0 does not exist on
the 36 key piantor.
Types of Changes
Issues Fixed or Closed by This PR
Checklist